Java Script no longer working after unknown code changes

[mzucal]

Did anyone have their custom Java Script break? We were hiding several buttons from faculty and suddenly they have reappered. No matter what I change my Java Script to I cannot hide the buttons from faculty.  I was tolde to replace my first line with if ($.inArray("admin", ENV.current_user_roles) == -1)  which doesn't work.

Does anyone know what in God's name they changed?

Thanks

Melissa

Here is the original code:

// Checks that current user role is is a teacher, Admins can see the buttons. Also allows Admins who are also Teachers
// to see the buttons. You many need to adjust the current user role name and ID to match the exceptions for your institution.
// You also may need to comment out buttons that you want to allow your teachers to see.

$(document).ready(function(){
if($.inArray('teacher',ENV['current_user_roles']) === 2 && $.inArray('admin',ENV['current_user_roles']) === 3 )
{
$('a.btn.button-sidebar-wide.reset_course_content_button').show();
$("a:contains('Conclude this Course')").show();
$('a.btn.button-sidebar-wide.delete_course_link').show();
}
else if
($.inArray('admin',ENV['current_user_roles']) === 2 || $.inArray('admin',ENV['current_user_roles']) === 3 ) {
$('a.btn.button-sidebar-wide.reset_course_content_button').show();
$("a:contains('Conclude this Course')").show();
$('a.btn.button-sidebar-wide.delete_course_link').show();
$("a:contains('Add Section')").hide();
}
else {
($.inArray('teacher',ENV['current_user_roles']) === 3 )
$('a.btn.button-sidebar-wide.reset_course_content_button').hide();
$("a:contains('Conclude this Course')").hide();
$('a.btn.button-sidebar-wide.delete_course_link').hide();
$('a.btn.button-sidebar-wide.crosslist_link').hide();
$("input#course_section_name").hide();
$("input#course_section_name").parent().hide();
}
});

[dgrobani]

After a quick glance at your code, I'm wondering if the issue might be your inArray tests. It looks to me like you're testing for a role to be in a particular position, which I'm not sure you can count on and which doesn't seem necessary to me.

I test for the admin role with this:

if (ENV.current_user_roles.indexOf('admin') > -1)‍

This checks for the presence of the role without requiring that it be in any particular position.

[Robbie_Grant]

 @mzucal ,

We are giving the Canvas Admins area a little bit of love (especially questions that are really, really old) and just want to check in with you.  This will also bring this question new attention. 

Were you able to find an answer to your question? I am going to go ahead and mark this question as answered because there hasn't been any more activity in a while so I assume that you have the information that you need. If you still have a question about this or if you have information that you would like to share with the community, by all means, please do come back and leave a comment.  Also, if this question has been answered by one of the previous replies, please feel free to mark that answer as correct.

Robbie

[Boekenoogen]

Instructure does warn us every time they update the production program of Canvas that some custom coding might break. We have a lot and have to check it every three weeks.